diff options
Diffstat (limited to 'net/bluetooth/l2cap_sock.c')
| -rw-r--r-- | net/bluetooth/l2cap_sock.c | 72 | 
1 files changed, 13 insertions, 59 deletions
| diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c index 7c4a9ae9b3ce..18dc9888d8c2 100644 --- a/net/bluetooth/l2cap_sock.c +++ b/net/bluetooth/l2cap_sock.c @@ -78,22 +78,6 @@ void l2cap_sock_clear_timer(struct sock *sk)  	sk_stop_timer(sk, &sk->sk_timer);  } -static struct sock *__l2cap_get_sock_by_addr(__le16 psm, bdaddr_t *src) -{ -	struct sock *sk; -	struct hlist_node *node; -	sk_for_each(sk, node, &l2cap_sk_list.head) { -		struct l2cap_chan *chan = l2cap_pi(sk)->chan; - -		if (chan->sport == psm && !bacmp(&bt_sk(sk)->src, src)) -			goto found; -	} - -	sk = NULL; -found: -	return sk; -} -  static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)  {  	struct sock *sk = sock->sk; @@ -136,26 +120,20 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)  		}  	} -	write_lock_bh(&l2cap_sk_list.lock); +	if (la.l2_cid) +		err = l2cap_add_scid(chan, la.l2_cid); +	else +		err = l2cap_add_psm(chan, &la.l2_bdaddr, la.l2_psm); -	if (la.l2_psm && __l2cap_get_sock_by_addr(la.l2_psm, &la.l2_bdaddr)) { -		err = -EADDRINUSE; -	} else { -		/* Save source address */ -		bacpy(&bt_sk(sk)->src, &la.l2_bdaddr); -		chan->psm   = la.l2_psm; -		chan->sport = la.l2_psm; -		sk->sk_state = BT_BOUND; - -		if (__le16_to_cpu(la.l2_psm) == 0x0001 || -					__le16_to_cpu(la.l2_psm) == 0x0003) -			chan->sec_level = BT_SECURITY_SDP; -	} +	if (err < 0) +		goto done; -	if (la.l2_cid) -		chan->scid = la.l2_cid; +	if (__le16_to_cpu(la.l2_psm) == 0x0001 || +				__le16_to_cpu(la.l2_psm) == 0x0003) +		chan->sec_level = BT_SECURITY_SDP; -	write_unlock_bh(&l2cap_sk_list.lock); +	bacpy(&bt_sk(sk)->src, &la.l2_bdaddr); +	sk->sk_state = BT_BOUND;  done:  	release_sock(sk); @@ -278,28 +256,6 @@ static int l2cap_sock_listen(struct socket *sock, int backlog)  		goto done;  	} -	if (!chan->psm && !chan->scid) { -		bdaddr_t *src = &bt_sk(sk)->src; -		u16 psm; - -		err = -EINVAL; - -		write_lock_bh(&l2cap_sk_list.lock); - -		for (psm = 0x1001; psm < 0x1100; psm += 2) -			if (!__l2cap_get_sock_by_addr(cpu_to_le16(psm), src)) { -				chan->psm   = cpu_to_le16(psm); -				chan->sport = cpu_to_le16(psm); -				err = 0; -				break; -			} - -		write_unlock_bh(&l2cap_sk_list.lock); - -		if (err < 0) -			goto done; -	} -  	sk->sk_max_ack_backlog = backlog;  	sk->sk_ack_backlog = 0;  	sk->sk_state = BT_LISTEN; @@ -852,8 +808,7 @@ void l2cap_sock_kill(struct sock *sk)  	/* Kill poor orphan */ -	l2cap_chan_free(l2cap_pi(sk)->chan); -	bt_sock_unlink(&l2cap_sk_list, sk); +	l2cap_chan_destroy(l2cap_pi(sk)->chan);  	sock_set_flag(sk, SOCK_DEAD);  	sock_put(sk);  } @@ -1069,7 +1024,6 @@ struct sock *l2cap_sock_alloc(struct net *net, struct socket *sock, int proto, g  	setup_timer(&sk->sk_timer, l2cap_sock_timeout, (unsigned long) sk); -	bt_sock_link(&l2cap_sk_list, sk);  	return sk;  } @@ -1096,7 +1050,7 @@ static int l2cap_sock_create(struct net *net, struct socket *sock, int protocol,  	if (!sk)  		return -ENOMEM; -	chan = l2cap_chan_alloc(sk); +	chan = l2cap_chan_create(sk);  	if (!chan) {  		l2cap_sock_kill(sk);  		return -ENOMEM; | 
