summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2021-08-02 16:10:00 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-09-03 10:23:08 +0200
commit49da19a8538335d7721bcc02b830221daef840b0 (patch)
tree27580c969e0a007caad2d9a3a1b21ffb7b534a14
parent4e25ac3793f76aec260a7158f5d897133afd70da (diff)
platform/x86: Make dual_accel_detect() KIOX010A + KIOX020A detect more robust
commit 085fc31f81765e061c78cdcab0e5516fd672bff7 upstream. 360 degree hinges devices with dual KIOX010A + KIOX020A accelerometers always have both a KIOX010A and a KIOX020A ACPI device (one for each accel). Theoretical some vendor may re-use some DSDT for a non-convertible stripping out just the KIOX020A ACPI device from the DSDT. Check that both ACPI devices are present to make the check more robust. Fixes: 153cca9caa81 ("platform/x86: Add and use a dual_accel_detect() helper") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20210802141000.978035-1-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/platform/x86/dual_accel_detect.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/dual_accel_detect.h b/drivers/platform/x86/dual_accel_detect.h
index 1a069159da91..a9eae17cc43d 100644
--- a/drivers/platform/x86/dual_accel_detect.h
+++ b/drivers/platform/x86/dual_accel_detect.h
@@ -60,7 +60,8 @@ static bool dual_accel_detect_bosc0200(void)
static bool dual_accel_detect(void)
{
/* Systems which use a pair of accels with KIOX010A / KIOX020A ACPI ids */
- if (acpi_dev_present("KIOX010A", NULL, -1))
+ if (acpi_dev_present("KIOX010A", NULL, -1) &&
+ acpi_dev_present("KIOX020A", NULL, -1))
return true;
/* Systems which use a single DUAL250E ACPI device to model 2 accels */