diff options
| author | Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> | 2023-03-06 11:18:24 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-04-05 11:14:22 +0200 |
| commit | a15fce1f17435e8b3ad7329fbd22ff4a2cb87093 (patch) | |
| tree | 49811f191300b6fa6b914c338ca687a579acb1b7 | |
| parent | c4b1e702dc841a79664c5b8000fd99ffe9b3e9c2 (diff) | |
ca8210: Fix unsigned mac_len comparison with zero in ca8210_skb_tx()
commit 748b2f5e82d17480404b3e2895388fc2925f7caf upstream.
mac_len is of type unsigned, which can never be less than zero.
mac_len = ieee802154_hdr_peek_addrs(skb, &header);
if (mac_len < 0)
return mac_len;
Change this to type int as ieee802154_hdr_peek_addrs() can return negative
integers, this is found by static analysis with smatch.
Fixes: 6c993779ea1d ("ca8210: fix mac_len negative array access")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230306191824.4115839-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/ieee802154/ca8210.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 76ca8c63bc379..4ec65582eaf70 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1944,10 +1944,9 @@ static int ca8210_skb_tx( struct ca8210_priv *priv ) { - int status; struct ieee802154_hdr header = { 0 }; struct secspec secspec; - unsigned int mac_len; + int mac_len, status; dev_dbg(&priv->spi->dev, "ca8210_skb_tx() called\n"); |