diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-04-30 19:34:08 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-13 08:52:59 +0100 |
| commit | b136eeb65de081668061c35f70e95309e97a54cf (patch) | |
| tree | 1c69c7dce043105ea5c64903c3a17a5febf80801 | |
| parent | 0977763a13fd87a7aebe376dc96385758de3aa9e (diff) | |
appletalk: Set error code if register_snap_client failed
commit c93ad1337ad06a718890a89cdd85188ff9a5a5cc upstream.
If register_snap_client fails in atalk_init,
error code should be set, otherwise it will
triggers NULL pointer dereference while unloading
module.
Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/appletalk/ddp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 943d66fd860c..2880ac470379 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1925,6 +1925,7 @@ static int __init atalk_init(void) ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); if (!ddp_dl) { pr_crit("Unable to register DDP with SNAP.\n"); + rc = -ENOMEM; goto out_sock; } |