TLS support for libpthread, Mach/Hurd (x86).

	* Makefile (CFLAGS): Define ENABLE_TLS.
	* pthread/pt-create.c (__pthread_create_internal) [ENABLE_TLS]: Call
	into glibc to allocate static TLS block.
	* pthread/pt-exit.c (pthread_exit) [ENABLE_TLS]: Call into glibc to
	deallocate static TLS block.
	* pthread/pt-internal.h [ENABLE_TLS] (tcbhead_t): New structure; as in
	glibc.
	(__pthread) [ENABLE_TLS]: Add TCB member.
	[ENABLE_TLS] (_dl_allocate_tls, _dl_deallocate_tls): Declare; from
	glibc.
	* sysdeps/mach/hurd/pt-sysdep.h (__thread_set_pcsp): Rename to
	__thread_set_pcsptp.  Add SET_TP and TP parameters.  Change all
	callers.
	* sysdeps/mach/hurd/i386/pt-machdep.c (__thread_set_pcsptp): Imlement
	TLS support.
	* sysdeps/mach/hurd/i386/pt-setup.c (__pthread_setup): Likewise.

10 files changed, 121 insertions, 20 deletions

diff --git a/ChangeLog b/ChangeLog
index 1337286..22665d2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,24 @@
+2007-06-13  Samuel Thibault  <samuel.thibault@ens-lyon.org>
+
+	TLS support for libpthread, Mach/Hurd (x86).
+
+	* Makefile (CFLAGS): Define ENABLE_TLS.
+	* pthread/pt-create.c (__pthread_create_internal) [ENABLE_TLS]: Call
+	into glibc to allocate static TLS block.
+	* pthread/pt-exit.c (pthread_exit) [ENABLE_TLS]: Call into glibc to
+	deallocate static TLS block.
+	* pthread/pt-internal.h [ENABLE_TLS] (tcbhead_t): New structure; as in
+	glibc.
+	(__pthread) [ENABLE_TLS]: Add TCB member.
+	[ENABLE_TLS] (_dl_allocate_tls, _dl_deallocate_tls): Declare; from
+	glibc.
+	* sysdeps/mach/hurd/pt-sysdep.h (__thread_set_pcsp): Rename to
+	__thread_set_pcsptp.  Add SET_TP and TP parameters.  Change all
+	callers.
+	* sysdeps/mach/hurd/i386/pt-machdep.c (__thread_set_pcsptp): Imlement
+	TLS support.
+	* sysdeps/mach/hurd/i386/pt-setup.c (__pthread_setup): Likewise.
+
 2006-03-04  Samuel Thibault  <samuel.thibault@ens-lyon.org>
 
 	* sysdeps/i386/machine-sp.h (thread_stack_pointer):
diff --git a/Makefile b/Makefile
index 3c5631a..ca63b97 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
 #
-#   Copyright (C) 1994,95,96,97,2000,02, 2004, 2005, 2006
+#   Copyright (C) 1994,95,96,97,2000,02, 2004, 2005, 2006, 2007
 #     Free Software Foundation, Inc.
 #
 #   This program is free software; you can redistribute it and/or
@@ -170,6 +170,7 @@ VPATH += $(SYSDEP_PATH)
 HURDLIBS = ihash
 
 CFLAGS := -D_IO_MTSAFE_IO				\
+	  -DENABLE_TLS					\
 	   $(addprefix -I, $(SYSDEP_PATH))		\
 	  -imacros $(srcdir)/include/libc-symbols.h	\
 	  -imacros $(srcdir)/not-in-libc.h
diff --git a/TODO b/TODO
index 30ca19c..c9ca81d 100644
--- a/TODO
+++ b/TODO
@@ -144,6 +144,9 @@
    Use them consistently and correctly and start by reading
    http://sources.redhat.com/ml/libc-alpha/2002-08/msg00278.html.
 
+** TLS
+  Support for TLS is only implemented for Mach/Hurd (x86).
+
 * L4 Specific Issues
 ** Stack
 *** Size
diff --git a/pthread/pt-create.c b/pthread/pt-create.c
index bad5d83..0d66d6c 100644
--- a/pthread/pt-create.c
+++ b/pthread/pt-create.c
@@ -1,5 +1,5 @@
 /* Thread creation.
-   Copyright (C) 2000, 2002, 2005 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2002, 2005, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -127,6 +127,13 @@ __pthread_create_internal (struct __pthread **thread,
   if (err)
     goto failed_thread_alloc;
 
+#ifdef ENABLE_TLS
+  pthread->tcb = _dl_allocate_tls (NULL);
+  if (!pthread->tcb)
+    goto failed_thread_tls_alloc;
+  pthread->tcb->tcb = pthread->tcb;
+#endif /* ENABLE_TLS */
+
   /* And initialize the rest of the machine context.  This may include
      additional machine- and system-specific initializations that
      prove convenient.  */
@@ -192,6 +199,10 @@ __pthread_create_internal (struct __pthread **thread,
  failed_sigstate:
   __pthread_sigstate_destroy (pthread);
  failed_setup:
+#ifdef ENABLE_TLS
+  _dl_deallocate_tls (pthread->tcb, 1);
+ failed_thread_tls_alloc:
+#endif /* ENABLE_TLS */
   __pthread_thread_dealloc (pthread);
   __pthread_thread_halt (pthread, 0);
  failed_thread_alloc:
diff --git a/pthread/pt-exit.c b/pthread/pt-exit.c
index 7484ffd..941526a 100644
--- a/pthread/pt-exit.c
+++ b/pthread/pt-exit.c
@@ -1,5 +1,5 @@
 /* Thread termination.
-   Copyright (C) 2000, 2002, 2005 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2002, 2005, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -70,6 +70,10 @@ pthread_exit (void *status)
   if (self->cancel_state == PTHREAD_CANCEL_ENABLE && self->cancel_pending)
     status = PTHREAD_CANCELED;
 
+#ifdef ENABLE_TLS
+  if (self->tcb)
+    _dl_deallocate_tls (self->tcb, 1);
+#endif /* ENABLE_TLS */
   __pthread_thread_dealloc (self);
 
   switch (self->state)
diff --git a/pthread/pt-internal.h b/pthread/pt-internal.h
index efd4ffb..159f1cb 100644
--- a/pthread/pt-internal.h
+++ b/pthread/pt-internal.h
@@ -1,5 +1,5 @@
 /* Internal defenitions for pthreads library.
-   Copyright (C) 2000, 2005 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2005, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -50,6 +50,16 @@ enum pthread_state
 # define PTHREAD_SYSDEP_MEMBERS
 #endif
 
+#ifdef ENABLE_TLS
+/* Type of the TCB.  */
+typedef struct
+{
+  void *tcb;			/* Points to this structure.  */
+  void *dtv;			/* Vector of pointers to TLS data.  */
+  thread_t self;		/* This thread's control port.  */
+} tcbhead_t;
+#endif /* ENABLE_TLS */
+
 /* This structure describes a POSIX thread.  */
 struct __pthread
 {
@@ -85,6 +95,10 @@ struct __pthread
 
   PTHREAD_SYSDEP_MEMBERS
 
+#ifdef ENABLE_TLS
+  tcbhead_t *tcb;
+#endif /* ENABLE_TLS */
+
   struct __pthread *next, **prevp;
 };
 
@@ -272,4 +286,17 @@ const struct __pthread_rwlockattr __pthread_default_rwlockattr;
 /* Default condition attributes.  */
 const struct __pthread_condattr __pthread_default_condattr;
 
+
+#ifdef ENABLE_TLS
+
+/* From glibc.  */
+
+/* Dynamic linker TLS allocation.  */
+extern void *_dl_allocate_tls(void *);
+
+/* Dynamic linker TLS deallocation.  */
+extern void _dl_deallocate_tls(void *, int);
+
+#endif /* ENABLE_TLS */
+
 #endif /* pt-internal.h */
diff --git a/sysdeps/mach/hurd/i386/pt-machdep.c b/sysdeps/mach/hurd/i386/pt-machdep.c
index face46c..f3c8cf5 100644
--- a/sysdeps/mach/hurd/i386/pt-machdep.c
+++ b/sysdeps/mach/hurd/i386/pt-machdep.c
@@ -1,5 +1,5 @@
 /* Machine dependent pthreads code.  Hurd/i386 version.
-   Copyright (C) 2000,02 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2002, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -21,12 +21,28 @@
 
 #include <mach.h>
 #include <mach/i386/thread_status.h>
+#include <mach/i386/mach_i386.h>
+#include <mach/mig_errors.h>
 #include <mach/thread_status.h>
 
+#define HURD_TLS_DESC_DECL(desc, tcb)					      \
+  struct descriptor desc =						      \
+    {				/* low word: */				      \
+      0xffff			/* limit 0..15 */			      \
+      | (((unsigned int) (tcb)) << 16) /* base 0..15 */			      \
+      ,				/* high word: */			      \
+      ((((unsigned int) (tcb)) >> 16) & 0xff) /* base 16..23 */		      \
+      | ((0x12 | 0x60 | 0x80) << 8) /* access = ACC_DATA_W|ACC_PL_U|ACC_P */  \
+      | (0xf << 16)		/* limit 16..19 */			      \
+      | ((4 | 8) << 20)		/* granularity = SZ_32|SZ_G */		      \
+      | (((unsigned int) (tcb)) & 0xff000000) /* base 24..31 */		      \
+    }
+
 int
-__thread_set_pcsp (thread_t thread,
+__thread_set_pcsptp (thread_t thread,
 		   int set_ip, void *ip,
-		   int set_sp, void *sp)
+		   int set_sp, void *sp,
+		   int set_tp, void *tp)
 {
   error_t err;
   struct i386_thread_state state;
@@ -34,7 +50,7 @@ __thread_set_pcsp (thread_t thread,
 
   state_count = i386_THREAD_STATE_COUNT;
 
-  err = __thread_get_state (thread, i386_THREAD_STATE,
+  err = __thread_get_state (thread, i386_REGS_SEGS_STATE,
 			    (thread_state_t) &state, &state_count);
   if (err)
     return err;
@@ -43,8 +59,21 @@ __thread_set_pcsp (thread_t thread,
     state.uesp = (unsigned int) sp;
   if (set_ip)
     state.eip = (unsigned int) ip;
+  if (set_tp) {
+    HURD_TLS_DESC_DECL(desc, tp);
+    int sel;
+
+    asm ("mov %%gs, %w0" : "=q" (sel) : "0" (0));
+    if (__builtin_expect (sel, 0x48) & 4) /* LDT selector */
+      err = __i386_set_ldt (thread, sel, &desc, 1);
+    else
+      err = __i386_set_gdt (thread, &sel, desc);
+    if (err)
+      return err;
+    state.gs = sel;
+  }
 
-  err = __thread_set_state (thread, i386_THREAD_STATE,
+  err = __thread_set_state (thread, i386_REGS_SEGS_STATE,
 			    (thread_state_t) &state,
 			    i386_THREAD_STATE_COUNT);
   if (err)
diff --git a/sysdeps/mach/hurd/i386/pt-setup.c b/sysdeps/mach/hurd/i386/pt-setup.c
index 32ace6a..020f677 100644
--- a/sysdeps/mach/hurd/i386/pt-setup.c
+++ b/sysdeps/mach/hurd/i386/pt-setup.c
@@ -1,5 +1,5 @@
 /* Setup thread stack.  Hurd/i386 version.
-   Copyright (C) 2000, 2002, 2005 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2002, 2005, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -89,12 +89,15 @@ __pthread_setup (struct __pthread *thread,
   thread->mcontext.pc = entry_point;
   thread->mcontext.sp = stack_setup (thread, start_routine, arg);
 
+  thread->tcb->self = thread->kernel_thread;
+
   ktid = __mach_thread_self ();
   if (thread->kernel_thread != ktid)
     {
-      err = __thread_set_pcsp (thread->kernel_thread,
+      err = __thread_set_pcsptp (thread->kernel_thread,
 			       1, thread->mcontext.pc,
-			       1, thread->mcontext.sp);
+			       1, thread->mcontext.sp,
+			       1, thread->tcb);
       assert_perror (err);
     }
   __mach_port_deallocate (__mach_task_self (), ktid);
diff --git a/sysdeps/mach/hurd/pt-docancel.c b/sysdeps/mach/hurd/pt-docancel.c
index bac62a7..84f04c0 100644
--- a/sysdeps/mach/hurd/pt-docancel.c
+++ b/sysdeps/mach/hurd/pt-docancel.c
@@ -1,5 +1,5 @@
 /* Cancel a thread.
-   Copyright (C) 2002 Free Software Foundation, Inc.
+   Copyright (C) 2002, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -52,8 +52,8 @@ __pthread_do_cancel (struct __pthread *p)
       err = __thread_abort (p->kernel_thread);
       assert_perror (err);
 
-      err = __thread_set_pcsp (p->kernel_thread,
-			       1, (void *) call_exit, 0, 0);
+      err = __thread_set_pcsptp (p->kernel_thread,
+			       1, (void *) call_exit, 0, 0, 0, 0);
       assert_perror (err);
 
       err = __thread_resume (p->kernel_thread);
diff --git a/sysdeps/mach/hurd/pt-sysdep.h b/sysdeps/mach/hurd/pt-sysdep.h
index 83bad96..f652b68 100644
--- a/sysdeps/mach/hurd/pt-sysdep.h
+++ b/sysdeps/mach/hurd/pt-sysdep.h
@@ -1,5 +1,5 @@
 /* Internal defenitions for pthreads library.
-   Copyright (C) 2000, 2002 Free Software Foundation, Inc.
+   Copyright (C) 2000, 2002, 2007 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -59,11 +59,13 @@ __pthread_stack_dealloc (void *stackaddr, size_t stacksize)
   __vm_deallocate (__mach_task_self (), (vm_offset_t) stackaddr, stacksize);
 }
 
-/* Change thread THREAD's program counter to PC if SET_PC is true and
-   its stack pointer to SP if SET_IP is true.  */
-extern int __thread_set_pcsp (thread_t thread,
+/* Change thread THREAD's program counter to PC if SET_PC is true,
+   its stack pointer to SP if SET_IP is true, and its thread pointer
+   to TP if SET_TP is true.  */
+extern int __thread_set_pcsptp (thread_t thread,
 			      int set_pc, void *pc,
-			      int set_sp, void *sp);
+			      int set_sp, void *sp,
+			      int set_tp, void *tp);
 
 
 #endif /* pt-sysdep.h */