summaryrefslogtreecommitdiff
path: root/sysdeps/unix
diff options
context:
space:
mode:
Diffstat (limited to 'sysdeps/unix')
-rw-r--r--sysdeps/unix/bsd/getpt.c25
-rw-r--r--sysdeps/unix/sysv/linux/ptsname.c12
2 files changed, 18 insertions, 19 deletions
diff --git a/sysdeps/unix/bsd/getpt.c b/sysdeps/unix/bsd/getpt.c
index ec339c8335..55d87fa2bc 100644
--- a/sysdeps/unix/bsd/getpt.c
+++ b/sysdeps/unix/bsd/getpt.c
@@ -31,13 +31,13 @@
#ifndef PTYNAME1
#define PTYNAME1 "pqrsPQRS"
#endif
-const char *__libc_ptyname1 = PTYNAME1;
+const char __libc_ptyname1[] = PTYNAME1;
/* Letters indicating the position within a series. */
#ifndef PTYNAME2
#define PTYNAME2 "0123456789abcdefghijklmnopqrstuv";
#endif
-const char *__libc_ptyname2 = PTYNAME2;
+const char __libc_ptyname2[] = PTYNAME2;
/* Open a master pseudo terminal and return its file descriptor. */
@@ -47,32 +47,31 @@ __getpt (void)
char buf[sizeof (_PATH_PTY) + 2];
const char *p, *q;
char *s;
-
- s = __stpcpy (buf, _PATH_PTY);
- s[0] = '?';
- s[1] = '?';
- s[2] = 0;
- for (p = __libc_ptyname1; *p; p++)
+ s = __mempcpy (buf, _PATH_PTY, sizeof (_PATH_PTY) - 1);
+ /* s[0] and s[1] will be filled in the loop. */
+ s[2] = '\0';
+
+ for (p = __libc_ptyname1; *p != '\0'; ++p)
{
s[0] = *p;
- for (q = __libc_ptyname2; *q; q++)
+ for (q = __libc_ptyname2; *q != '\0'; ++q)
{
int fd;
-
+
s[1] = *q;
-
+
fd = __open (buf, O_RDWR);
if (fd != -1)
{
if (__isatty (fd))
return fd;
-
+
__close (fd);
continue;
}
-
+
if (errno != EIO)
return -1;
}
diff --git a/sysdeps/unix/sysv/linux/ptsname.c b/sysdeps/unix/sysv/linux/ptsname.c
index 048ac96551..d852fb3658 100644
--- a/sysdeps/unix/sysv/linux/ptsname.c
+++ b/sysdeps/unix/sysv/linux/ptsname.c
@@ -33,8 +33,8 @@
#define _PATH_DEVPTS "/dev/pts/"
/* The are declared in getpt.c. */
-extern const char *__libc_ptyname1;
-extern const char *__libc_ptyname2;
+extern const char __libc_ptyname1[];
+extern const char __libc_ptyname2[];
/* Static buffer for `ptsname'. */
static char buffer[sizeof (_PATH_DEVPTS) + 20];
@@ -59,7 +59,7 @@ __ptsname_r (int fd, char *buf, size_t buflen)
int save_errno = errno;
struct stat st;
int ptyno;
-
+
if (buf == NULL)
{
__set_errno (EINVAL);
@@ -97,7 +97,7 @@ __ptsname_r (int fd, char *buf, size_t buflen)
#endif
{
char *p;
-
+
if (buflen < strlen (_PATH_TTY) + 3)
{
__set_errno (ERANGE);
@@ -116,13 +116,13 @@ __ptsname_r (int fd, char *buf, size_t buflen)
__set_errno (ENOTTY);
return ENOTTY;
}
-
+
p = __stpcpy (buf, _PATH_TTY);
p[0] = __libc_ptyname1[ptyno / 16];
p[1] = __libc_ptyname2[ptyno % 16];
p[2] = '\0';
}
-
+
if (__stat (buf, &st) < 0)
return errno;