diff options
| author | Florian Weimer <fweimer@redhat.com> | 2018-02-21 10:37:22 +0100 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2018-02-21 10:37:22 +0100 |
| commit | 52a01100ad011293197637e42b5be1a479a2f4ae (patch) | |
| tree | 8bfbd570b7eda10ee7de5fcb8ce430c1043af0f0 /include | |
| parent | b5bf62e40c5ff4e3906572f257dcda77b393ffa0 (diff) | |
elf: Remove ad-hoc restrictions on dlopen callers [BZ #22787]
This looks like a post-exploitation hardening measure: If an attacker is
able to redirect execution flow, they could use that to load a DSO which
contains additional code (or perhaps make the stack executable).
However, the checks are not in the correct place to be effective: If
they are performed before the critical operation, an attacker with
sufficient control over execution flow could simply jump directly to
the code which performs the operation, bypassing the check. The check
would have to be executed unconditionally after the operation and
terminate the process in case a caller violation was detected.
Furthermore, in _dl_check_caller, there was a fallback reading global
writable data (GL(dl_rtld_map).l_map_start and
GL(dl_rtld_map).l_text_end), which could conceivably be targeted by an
attacker to disable the check, too.
Other critical functions (such as system) remain completely
unprotected, so the value of these additional checks does not appear
that large. Therefore this commit removes this functionality.
Diffstat (limited to 'include')
| -rw-r--r-- | include/caller.h | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/include/caller.h b/include/caller.h deleted file mode 100644 index 3a4a4b7de8..0000000000 --- a/include/caller.h +++ /dev/null @@ -1,31 +0,0 @@ -/* Copyright (C) 2004-2018 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - <http://www.gnu.org/licenses/>. */ - -#ifndef _CALLER_H -#define _CALLER_H 1 - -#include <ldsodefs.h> - -/* _dl_check_caller only works in DSOs. */ -#ifdef SHARED -# define __check_caller(caller, mask) \ - GLRO(dl_check_caller) (caller, mask) -#else -# define __check_caller(caller, mask) (0) -#endif - -#endif /* caller.h */ |