summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-02-07 23:23:36 +0000
committerDavid S. Miller <davem@davemloft.net>2012-02-08 19:57:55 -0500
commita584b7ae4ef01425f6827657abdc3e4db49b3578 (patch)
tree6bd2487c7c4b6338978c20768c388f2ce9a07699
parent039055b965b9cfbeacb8cdcd1ef57e18b6374e58 (diff)
netxen_nic: signedness bug in netxen_md_entry_err_chk()
"esize" should be signed because it can be negative here. For example, when we call it in netxen_parse_md_template(), it could be -1 from the return value of netxen_md_L2Cache(). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
index 0a812285102..6f37470750f 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
*/
static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
- struct netxen_minidump_entry *entry, u32 esize)
+ struct netxen_minidump_entry *entry, int esize)
{
if (esize < 0) {
entry->hdr.driver_flags |= NX_DUMP_SKIP;