summaryrefslogtreecommitdiff
path: root/xhfc
diff options
context:
space:
mode:
authorGuillaume Knispel <gknispel@proformatique.com>2012-02-14 18:37:08 +0100
committerGuillaume Knispel <gknispel@proformatique.com>2012-02-14 18:37:08 +0100
commit31a6429bd5b4cc283b8d9336fb3e579b70705ac8 (patch)
treeb0c98b8c37542ce50192d09ea30f61e61fb40a75 /xhfc
parent69e2bae4a5c19c430000a3628056877594ae1a7f (diff)
fix module doc + a comment, add an XXX
Diffstat (limited to 'xhfc')
-rw-r--r--xhfc/base.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/xhfc/base.c b/xhfc/base.c
index d835679..0d12d1f 100644
--- a/xhfc/base.c
+++ b/xhfc/base.c
@@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Debug bitfield:\n"
"\t0: general\n"
//"\t2: verbose register access, only if DEBUG is defined\n"
"\t3: file operations\n"
- "\t4: (not used, echo canceller)\n"
"\t5: ST state\n"
"\t6: HDLC\n"
"\t7: HDLC (verbose)\n"
@@ -126,6 +125,7 @@ MODULE_PARM_DESC(exit_after_reset, "Exit after hard reset");
static void xhfc_waitbusy(struct xhfc *xhfc)
{
+ // XXX add timeout
while (read_xhfc(xhfc, R_STATUS) & M_BUSY)
cpu_relax();
}
@@ -612,8 +612,8 @@ static irqreturn_t xhfc_interrupt(int irq, void *dev_id)
xhfc = &pi->xhfc;
- /* IRQs for other HW with shared IRQ or spurious
- * XXX for XiVO OpenHardware we should not share IRQ! */
+ /* Not for us / spurious interrupt.
+ * (NOTE: for XiVO OpenHardware we don't share IRQ) */
if (!(read_xhfc(xhfc, R_IRQ_OVIEW)))
return IRQ_NONE;