From bdd785431c87d1a3362c69650415cadfc0c4adc5 Mon Sep 17 00:00:00 2001
From: Remy Noel <mocramis@gmail.com>
Date: Thu, 3 May 2018 14:27:24 +0200
Subject: perfmon: Remove useless accessors.

Also rename pmc oveflow handling function.
---
 arch/x86/machine/pmu_intel.c |  2 +-
 kern/perfmon.c               | 22 +---------------------
 kern/perfmon.h               | 16 ++++------------
 3 files changed, 6 insertions(+), 34 deletions(-)

diff --git a/arch/x86/machine/pmu_intel.c b/arch/x86/machine/pmu_intel.c
index e5d9ef7..6fbdbae 100644
--- a/arch/x86/machine/pmu_intel.c
+++ b/arch/x86/machine/pmu_intel.c
@@ -312,7 +312,7 @@ pmu_intel_handle_of_intr_v2(void)
             break;
         }
 
-        perfmon_cpu_pmc_inc_of(pmc_id);
+        perfmon_cpu_on_pmc_of(pmc_id);
     }
 }
 
diff --git a/kern/perfmon.c b/kern/perfmon.c
index 0211141..c910069 100644
--- a/kern/perfmon.c
+++ b/kern/perfmon.c
@@ -444,28 +444,8 @@ perfmon_cpu_pmu_get_pmc_from_id(unsigned int pmc_id)
     return cpu_pmc;
 }
 
-uint64_t
-perfmon_cpu_pmc_get_prev(unsigned int pmc_id)
-{
-    struct perfmon_cpu_pmc *cpu_pmc;
-
-    cpu_pmc = perfmon_cpu_pmu_get_pmc_from_id(pmc_id);
-
-    return cpu_pmc->prev_value;
-}
-
-void
-perfmon_cpu_pmc_set_prev(unsigned int pmc_id, uint64_t prev)
-{
-    struct perfmon_cpu_pmc *cpu_pmc;
-
-    cpu_pmc = perfmon_cpu_pmu_get_pmc_from_id(pmc_id);
-
-    cpu_pmc->prev_value = prev;
-}
-
 void
-perfmon_cpu_pmc_inc_of(unsigned int pmc_id)
+perfmon_cpu_on_pmc_of(unsigned int pmc_id)
 {
     struct perfmon_cpu_pmc *cpu_pmc;
 
diff --git a/kern/perfmon.h b/kern/perfmon.h
index cd7eb3a..b1da4ec 100644
--- a/kern/perfmon.h
+++ b/kern/perfmon.h
@@ -242,18 +242,10 @@ void perfmon_of_intr(void);
 int perfmon_pmu_register(struct perfmon_pmu_driver *driver);
 
 /*
- * Get the last value of given pmc.
- */
-uint64_t perfmon_cpu_pmc_get_prev(unsigned int pmc_id);
-
-/*
- * Set the last value of given pmc.
- */
-void perfmon_cpu_pmc_set_prev(unsigned int pmc_id, uint64_t prev);
-
-/*
- * Increment overflow counter for given pmc.
+ * Signal overflow for given pmc.
+ *
+ * Should be called from a pmu driver custom overflow interrupt handler.
  */
-void perfmon_cpu_pmc_inc_of(unsigned int pmc_id);
+void perfmon_cpu_on_pmc_of(unsigned int pmc_id);
 
 #endif /* KERN_PERFMON_H */
-- 
cgit v1.2.3