From 00d56229671b23f4cc459f96165dec41ef5988b4 Mon Sep 17 00:00:00 2001 From: Petr Machata Date: Fri, 1 Jun 2018 00:37:44 +0200 Subject: selftests: forwarding: mirror_vlan: Uninstall trap Instead of installing a trap before tests run and uninstalling it after they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo. Signed-off-by: Petr Machata Signed-off-by: David S. Miller --- tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh index 20b37a53657e0..f7124038b6c13 100755 --- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh +++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh @@ -108,7 +108,7 @@ test_all() tests_run - trap_install $h3 ingress + trap_uninstall $h3 ingress slow_path_trap_uninstall $swp1 egress slow_path_trap_uninstall $swp1 ingress } -- cgit v1.2.3 From 6ebe5a7a66ebd78f83fdd231a1d50bfc7a93598e Mon Sep 17 00:00:00 2001 From: Petr Machata Date: Fri, 1 Jun 2018 00:37:47 +0200 Subject: selftests: forwarding: mirror_vlan: Change test description The test description is displayed with the PASS/FAIL resolution after the test is ran. There however already is one other test described exactly like this, which makes it unclear which of the tests passed or failed. Make the description unique. Signed-off-by: Petr Machata Signed-off-by: David S. Miller --- tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh index f7124038b6c13..9ab2ce77b332c 100755 --- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh +++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh @@ -91,7 +91,7 @@ test_tagged_vlan_dir() 192.0.2.17 192.0.2.18 mirror_uninstall $swp1 $direction - log_test "$direction mirror to vlan ($tcflags)" + log_test "$direction mirror tagged to vlan ($tcflags)" } test_tagged_vlan() -- cgit v1.2.3