From 5d8ef852fce5c86756bfd05cbbc5b05351dd9ced Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 8 Feb 2015 00:02:52 +0100 Subject: Address comments --- sysdeps/mach/hurd/ftok.c | 9 +++++---- sysdeps/mach/hurd/shmat.c | 6 +++++- sysdeps/mach/hurd/shmctl.c | 5 +++-- sysdeps/mach/hurd/shmdt.c | 3 ++- sysdeps/mach/hurd/shmget.c | 5 +++-- 5 files changed, 18 insertions(+), 10 deletions(-) (limited to 'sysdeps') diff --git a/sysdeps/mach/hurd/ftok.c b/sysdeps/mach/hurd/ftok.c index 69e6bf58ff..a6aba15c86 100644 --- a/sysdeps/mach/hurd/ftok.c +++ b/sysdeps/mach/hurd/ftok.c @@ -1,6 +1,6 @@ -/* Copyright (C) 1995-2015 Free Software Foundation, Inc. +/* SysV ftok for Hurd. + Copyright (C) 1995-2015 Free Software Foundation, Inc. This file is part of the GNU C Library. - Contributed by Ulrich Drepper , August 1995. The GNU C Library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public @@ -21,8 +21,9 @@ /* In the Hurd, we use the second-to-most-significant bit as flag for - private keys. We use a different order of the components so that - the biggest one---the inode number---is affected by this. */ + private keys. We use an order of the components different from the generic + code in sysvipc/ftok.c so that the biggest one--the inode number--is + affected by this. */ key_t ftok (pathname, proj_id) diff --git a/sysdeps/mach/hurd/shmat.c b/sysdeps/mach/hurd/shmat.c index a8900e0a3f..6bc88705b8 100644 --- a/sysdeps/mach/hurd/shmat.c +++ b/sysdeps/mach/hurd/shmat.c @@ -1,4 +1,5 @@ -/* Copyright (C) 2005-2015 Free Software Foundation, Inc. +/* SysV shmat for Hurd. + Copyright (C) 2005-2015 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -53,7 +54,9 @@ __shmat (int shmid, const void *shmaddr, int shmflg) res = __fstat (fd, &statbuf); if (res < 0) { + err = errno; __close (fd); + errno = err; return (void *) -1; } @@ -68,6 +71,7 @@ __shmat (int shmid, const void *shmaddr, int shmflg) if (err) { munmap (addr, statbuf.st_size); + errno = err; return (void *) -1; } diff --git a/sysdeps/mach/hurd/shmctl.c b/sysdeps/mach/hurd/shmctl.c index aee5e15a56..a991a0c8de 100644 --- a/sysdeps/mach/hurd/shmctl.c +++ b/sysdeps/mach/hurd/shmctl.c @@ -1,4 +1,5 @@ -/* Copyright (C) 2005-2015 Free Software Foundation, Inc. +/* SysV shmctl for Hurd. + Copyright (C) 2005-2015 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -26,7 +27,7 @@ #include "sysvshm.h" -/* Provide operations to control over shared memory segments. */ +/* Provide operations to control shared memory segments. */ int __shmctl (int id, int cmd, struct shmid_ds *buf) { diff --git a/sysdeps/mach/hurd/shmdt.c b/sysdeps/mach/hurd/shmdt.c index 245fd55a89..988fab8ee6 100644 --- a/sysdeps/mach/hurd/shmdt.c +++ b/sysdeps/mach/hurd/shmdt.c @@ -1,4 +1,5 @@ -/* Copyright (C) 2005-2015 Free Software Foundation, Inc. +/* SysV shmdt for Hurd. + Copyright (C) 2005-2015 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or diff --git a/sysdeps/mach/hurd/shmget.c b/sysdeps/mach/hurd/shmget.c index 9b580949b8..2065b41989 100644 --- a/sysdeps/mach/hurd/shmget.c +++ b/sysdeps/mach/hurd/shmget.c @@ -1,4 +1,5 @@ -/* Copyright (C) 2005-2015 Free Software Foundation, Inc. +/* SysV shmget for Hurd. + Copyright (C) 2005-2015 Free Software Foundation, Inc. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -94,7 +95,7 @@ get_exclusive (int shmflags, size_t size, key_t *r_key, int *r_fd) key = SHM_PRIV_KEY_START; /* Try to link the shared memory segment into the filesystem - (exclusively). Private segments have negative keys. */ + (exclusively). */ do { sprintf (filename, SHM_NAMEPRI, key); -- cgit v1.2.3