From 8608ae1f7ba31f2149f9620a1339020339eac00d Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Fri, 6 Nov 2009 09:30:56 -0800 Subject: Properly handle STT_GNU_IFUNC symbols in do_sym. do_sym should use DL_FIXUP_VALUE_XXX macros to call IFUNC function. Otherwise, it won't compile on ia64. This patch fixes it and adds a test. --- elf/dl-sym.c | 9 +++++++-- elf/ifuncmain3.c | 9 +++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) (limited to 'elf') diff --git a/elf/dl-sym.c b/elf/dl-sym.c index 459729f0f2..0fa3b3ae47 100644 --- a/elf/dl-sym.c +++ b/elf/dl-sym.c @@ -193,8 +193,13 @@ RTLD_NEXT used in code not dynamically loaded")); /* Resolve indirect function address. */ if (__builtin_expect (ELFW(ST_TYPE) (ref->st_info) == STT_GNU_IFUNC, 0)) - value - = ((DL_FIXUP_VALUE_TYPE (*) (void)) DL_FIXUP_VALUE_ADDR (value)) (); + { + DL_FIXUP_VALUE_TYPE fixup + = DL_FIXUP_MAKE_VALUE (result, (ElfW(Addr)) value); + fixup = + ((DL_FIXUP_VALUE_TYPE (*) (void)) DL_FIXUP_VALUE_ADDR (fixup)) (); + value = (void *) DL_FIXUP_VALUE_CODE_ADDR (fixup); + } #ifdef SHARED /* Auditing checkpoint: we have a new binding. Provide the diff --git a/elf/ifuncmain3.c b/elf/ifuncmain3.c index 5d067cced9..1574dd5cbe 100644 --- a/elf/ifuncmain3.c +++ b/elf/ifuncmain3.c @@ -46,6 +46,15 @@ main (void) return 1; } + p = dlsym (h, "foo"); + if (p == NULL) + { + printf ("symbol not found: %s\n", dlerror ()); + return 1; + } + if ((*p) () != -1) + abort (); + f = dlsym (h, "get_foo_p"); if (f == NULL) { -- cgit v1.2.3 From 639d6699e9943c393f5fb5a9b84ab24e20bb7a93 Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Fri, 6 Nov 2009 09:34:23 -0800 Subject: Fix up whitespaces. --- elf/dl-sym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'elf') diff --git a/elf/dl-sym.c b/elf/dl-sym.c index 0fa3b3ae47..4faf05c00b 100644 --- a/elf/dl-sym.c +++ b/elf/dl-sym.c @@ -196,7 +196,7 @@ RTLD_NEXT used in code not dynamically loaded")); { DL_FIXUP_VALUE_TYPE fixup = DL_FIXUP_MAKE_VALUE (result, (ElfW(Addr)) value); - fixup = + fixup = ((DL_FIXUP_VALUE_TYPE (*) (void)) DL_FIXUP_VALUE_ADDR (fixup)) (); value = (void *) DL_FIXUP_VALUE_CODE_ADDR (fixup); } -- cgit v1.2.3