From e1fe91180e4e29549f35f8ecd705b0bb4f208606 Mon Sep 17 00:00:00 2001 From: Stefan Liebler Date: Wed, 26 Aug 2015 10:26:22 +0200 Subject: S390: Optimize strncat wcsncat. This patch provides optimized versions of strncat and wcsncat with the z13 vector instructions. ChangeLog: * sysdeps/s390/multiarch/strncat-c.c: New File. * sysdeps/s390/multiarch/strncat-vx.S: Likewise. * sysdeps/s390/multiarch/strncat.c: Likewise. * sysdeps/s390/multiarch/wcsncat-c.c: Likewise. * sysdeps/s390/multiarch/wcsncat-vx.S: Likewise. * sysdeps/s390/multiarch/wcsncat.c: Likewise. * sysdeps/s390/multiarch/Makefile (sysdep_routines): Add strncat and wcsncat functions. * sysdeps/s390/multiarch/ifunc-impl-list.c (__libc_ifunc_impl_list): Add ifunc test for strncat, wcsncat. * wcsmbs/wcsncat.c (WCSNCAT): Define and use macro. * string/test-strncat.c: Add wcsncat support. * wcsmbs/test-wcsncat.c: New File. * wcsmbs/Makefile (strop-tests): Add wcsncat. * benchtests/bench-strncat.c: Add wcsncat support. * benchtests/bench-wcsncat.c: New File. * benchtests/Makefile (wcsmbs-bench): Add wcsncat. --- benchtests/Makefile | 2 +- benchtests/bench-strncat.c | 97 +++++++++++++++++++++++++++++----------------- benchtests/bench-wcsncat.c | 20 ++++++++++ 3 files changed, 82 insertions(+), 37 deletions(-) create mode 100644 benchtests/bench-wcsncat.c (limited to 'benchtests') diff --git a/benchtests/Makefile b/benchtests/Makefile index 7c724fbda6..44a0471cc2 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -36,7 +36,7 @@ string-bench := bcopy bzero memccpy memchr memcmp memcpy memmem memmove \ strncasecmp strncat strncmp strncpy strnlen strpbrk strrchr \ strspn strstr strcpy_chk stpcpy_chk memrchr strsep strtok \ strcoll -wcsmbs-bench := wcslen wcsnlen wcscpy wcpcpy wcsncpy wcpncpy wcscat +wcsmbs-bench := wcslen wcsnlen wcscpy wcpcpy wcsncpy wcpncpy wcscat wcsncat string-bench-all := $(string-bench) ${wcsmbs-bench} # We have to generate locales diff --git a/benchtests/bench-strncat.c b/benchtests/bench-strncat.c index 85a313514f..8f3339dc78 100644 --- a/benchtests/bench-strncat.c +++ b/benchtests/bench-strncat.c @@ -17,33 +17,58 @@ . */ #define TEST_MAIN -#define TEST_NAME "strncat" +#ifndef WIDE +# define TEST_NAME "strncat" +#else +# define TEST_NAME "wcsncat" +#endif /* WIDE */ #include "bench-string.h" -typedef char *(*proto_t) (char *, const char *, size_t); -char *stupid_strncat (char *, const char *, size_t); -char *simple_strncat (char *, const char *, size_t); - -IMPL (stupid_strncat, 0) -IMPL (strncat, 2) - -char * -stupid_strncat (char *dst, const char *src, size_t n) +#ifndef WIDE +# define STRNCAT strncat +# define CHAR char +# define SIMPLE_STRNCAT simple_strncat +# define STUPID_STRNCAT stupid_strncat +# define STRLEN strlen +# define MEMCMP memcmp +# define BIG_CHAR CHAR_MAX +# define SMALL_CHAR 127 +#else +# include +# define STRNCAT wcsncat +# define CHAR wchar_t +# define SIMPLE_STRNCAT simple_wcsncat +# define STUPID_STRNCAT stupid_wcsncat +# define STRLEN wcslen +# define MEMCMP wmemcmp +# define BIG_CHAR WCHAR_MAX +# define SMALL_CHAR 1273 +#endif /* WIDE */ + +typedef CHAR *(*proto_t) (CHAR *, const CHAR *, size_t); +CHAR *STUPID_STRNCAT (CHAR *, const CHAR *, size_t); +CHAR *SIMPLE_STRNCAT (CHAR *, const CHAR *, size_t); + +IMPL (STUPID_STRNCAT, 0) +IMPL (STRNCAT, 2) + +CHAR * +STUPID_STRNCAT (CHAR *dst, const CHAR *src, size_t n) { - char *ret = dst; + CHAR *ret = dst; while (*dst++ != '\0'); --dst; while (n--) - if ( (*dst++ = *src++) == '\0') + if ((*dst++ = *src++) == '\0') return ret; *dst = '\0'; return ret; } static void -do_one_test (impl_t *impl, char *dst, const char *src, size_t n) +do_one_test (impl_t *impl, CHAR *dst, const CHAR *src, size_t n) { - size_t k = strlen (dst), i, iters = INNER_LOOP_ITERS; + size_t k = STRLEN (dst), i, iters = INNER_LOOP_ITERS; timing_t start, stop, cur; if (CALL (impl, dst, src, n) != dst) @@ -54,10 +79,10 @@ do_one_test (impl_t *impl, char *dst, const char *src, size_t n) return; } - size_t len = strlen (src); - if (memcmp (dst + k, src, len + 1 > n ? n : len + 1) != 0) + size_t len = STRLEN (src); + if (MEMCMP (dst + k, src, len + 1 > n ? n : len + 1) != 0) { - error (0, 0, "Incorrect cancatination in function %s", + error (0, 0, "Incorrect concatenation in function %s", impl->name); ret = 1; return; @@ -88,20 +113,20 @@ do_test (size_t align1, size_t align2, size_t len1, size_t len2, size_t n, int max_char) { size_t i; - char *s1, *s2; + CHAR *s1, *s2; align1 &= 7; - if (align1 + len1 >= page_size) + if ((align1 + len1) * sizeof (CHAR) >= page_size) return; - if (align1 + n > page_size) + if ((align1 + n) * sizeof (CHAR) > page_size) return; align2 &= 7; - if (align2 + len1 + len2 >= page_size) + if ((align2 + len1 + len2) * sizeof (CHAR) >= page_size) return; - if (align2 + len1 + n > page_size) + if ((align2 + len1 + n) * sizeof (CHAR) > page_size) return; - s1 = (char *) (buf1 + align1); - s2 = (char *) (buf2 + align2); + s1 = (CHAR *) (buf1) + align1; + s2 = (CHAR *) (buf2) + align2; for (i = 0; i < len1; ++i) s1[i] = 32 + 23 * i % (max_char - 32); @@ -136,25 +161,25 @@ main (void) for (n = 2; n <= 2048; n*=4) { - do_test (0, 2, 2, 2, n, 127); - do_test (0, 0, 4, 4, n, 127); - do_test (4, 0, 4, 4, n, 255); - do_test (0, 0, 8, 8, n, 127); - do_test (0, 8, 8, 8, n, 127); + do_test (0, 2, 2, 2, n, SMALL_CHAR); + do_test (0, 0, 4, 4, n, SMALL_CHAR); + do_test (4, 0, 4, 4, n, BIG_CHAR); + do_test (0, 0, 8, 8, n, SMALL_CHAR); + do_test (0, 8, 8, 8, n, SMALL_CHAR); for (i = 1; i < 8; ++i) { - do_test (0, 0, 8 << i, 8 << i, n, 127); - do_test (8 - i, 2 * i, 8 << i, 8 << i, n, 127); - do_test (0, 0, 8 << i, 2 << i, n, 127); - do_test (8 - i, 2 * i, 8 << i, 2 << i, n, 127); + do_test (0, 0, 8 << i, 8 << i, n, SMALL_CHAR); + do_test (8 - i, 2 * i, 8 << i, 8 << i, n, SMALL_CHAR); + do_test (0, 0, 8 << i, 2 << i, n, SMALL_CHAR); + do_test (8 - i, 2 * i, 8 << i, 2 << i, n, SMALL_CHAR); } for (i = 1; i < 8; ++i) { - do_test (i, 2 * i, 8 << i, 1, n, 127); - do_test (2 * i, i, 8 << i, 1, n, 255); - do_test (i, i, 8 << i, 10, n, 127); + do_test (i, 2 * i, 8 << i, 1, n, SMALL_CHAR); + do_test (2 * i, i, 8 << i, 1, n, BIG_CHAR); + do_test (i, i, 8 << i, 10, n, SMALL_CHAR); } } diff --git a/benchtests/bench-wcsncat.c b/benchtests/bench-wcsncat.c new file mode 100644 index 0000000000..b9d7c3f323 --- /dev/null +++ b/benchtests/bench-wcsncat.c @@ -0,0 +1,20 @@ +/* Measure wcsncat functions. + Copyright (C) 2015 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define WIDE 1 +#include "bench-strncat.c" -- cgit v1.2.3