From d7025badd8bae7ff8bc37551d868a22832a7bc94 Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Tue, 13 Oct 2015 23:30:20 +0000 Subject: Fix powerpc32 llround, llroundf exceptions (bug 19125). The powerpc32 implementations of llroundf and llround produce spurious and missing exceptions (some arising from such exceptions from conversions to long long, some present even when fctidz is used). This patch fixes those problems in a similar way to the llrint / llrintf fixes. The spurious exceptions in the fctidz case for large arguments arise from a converted value that saturated as LLONG_MAX being converted back to float or double (the conversion back being inexact, but "inexact" must not be raised together with "invalid"), and from the subtraction x - xrf also being inexact for sufficiently large arguments (whether the saturation was to LLONG_MAX or LLONG_MIN); those are fixed by returning early if the argument is large enough that no rounding is needed. This code is not used for --with-cpu=power4 builds (I suspect the code used in that case may also produce spurious "inexact" exceptions, but that's something to investigate later). Tested for powerpc. [BZ #19125] * sysdeps/powerpc/powerpc32/fpu/s_llround.c: Include , and . (__llround): Avoid conversions to and from long long int, and subtractions, where those might raise spurious exceptions. * sysdeps/powerpc/powerpc32/fpu/s_llroundf.c: Include and . (__llroundf): Avoid conversions to and from long long int, and subtractions, where those might raise spurious exceptions. --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'NEWS') diff --git a/NEWS b/NEWS index 7f39543638..6d39148afc 100644 --- a/NEWS +++ b/NEWS @@ -19,7 +19,7 @@ Version 2.23 18870, 18872, 18873, 18875, 18887, 18921, 18951, 18952, 18956, 18961, 18966, 18967, 18969, 18970, 18977, 18980, 18981, 18985, 19003, 19012, 19016, 19018, 19032, 19046, 19049, 19050, 19059, 19071, 19076, 19077, - 19078, 19079, 19085, 19086, 19088, 19094, 19095, 19124 + 19078, 19079, 19085, 19086, 19088, 19094, 19095, 19124, 19125 * The obsolete header has been removed. Programs that require this header must be updated to use instead. -- cgit v1.2.3