From 06d97e5e6100641df2c379459e41b26bb4d7648b Mon Sep 17 00:00:00 2001 From: Joseph Myers Date: Fri, 9 Oct 2015 21:02:19 +0000 Subject: Fix lrint, llrint, lround, llround missing exceptions for MIPS (bug 16399). For 32-bit MIPS and some other systems, various of the lrint, llrint, lround, llround functions can be missing exceptions on overflow because casts do not (in current GCC) result in the proper exceptions. In the MIPS case there are two problems here: MIPS I code generation uses an assembler macro that doesn't raise exceptions, while the libgcc conversions of floating-point values to long long also do not raise "invalid" on all overflow cases (and can raise spurious "inexact"). This patch adds support in the generic code (only the functions for which this problem has actually been seen) for forcing the "invalid" exception in the problem cases, and enables that support for the affected MIPS cases. Tested for MIPS; also tested for x86_64 and x86 that installed stripped shared libraries are unchanged by this patch. [BZ #16399] * sysdeps/generic/fix-fp-int-convert-overflow.h: New file. * sysdeps/ieee754/dbl-64/s_llrint.c: Include , and . (__llrint) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/dbl-64/s_llround.c: Include , and . (__llround) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/dbl-64/s_lrint.c: Include . (__lrint) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/dbl-64/s_lround.c: Include . (__lround) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_llrintf.c: Include , and . (__llrintf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_llroundf.c: Include , and . (__llroundf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_lrintf.c: Include , and . (__lrintf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/ieee754/flt-32/s_lroundf.c: Include , and . (__lroundf) [FE_INVALID]: Force FE_INVALID exception as needed if FIX_DBL_LLONG_CONVERT_OVERFLOW. * sysdeps/mips/mips32/fpu/fix-fp-int-convert-overflow.h: New file. --- ChangeLog | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index c47fd6d899..1e9a477895 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,41 @@ +2015-10-09 Joseph Myers + + [BZ #16399] + * sysdeps/generic/fix-fp-int-convert-overflow.h: New file. + * sysdeps/ieee754/dbl-64/s_llrint.c: Include , + and . + (__llrint) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/dbl-64/s_llround.c: Include , + and . + (__llround) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/dbl-64/s_lrint.c: Include + . + (__lrint) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/dbl-64/s_lround.c: Include + . + (__lround) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/flt-32/s_llrintf.c: Include , + and . + (__llrintf) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/flt-32/s_llroundf.c: Include , + and . + (__llroundf) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/flt-32/s_lrintf.c: Include , + and . + (__lrintf) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/ieee754/flt-32/s_lroundf.c: Include , + and . + (__lroundf) [FE_INVALID]: Force FE_INVALID exception as needed if + FIX_DBL_LLONG_CONVERT_OVERFLOW. + * sysdeps/mips/mips32/fpu/fix-fp-int-convert-overflow.h: New file. + 2015-10-09 Carlos O'Donell [BZ #18589] -- cgit v1.2.3